android(feat):new arch support #4675
Conversation
# Conflicts: # detox/android/detox/src/full/java/com/wix/detox/reactnative/idlingresources/animations/AnimatedModuleIdlingResource.kt
Change the way of getting is fabric enabled
Change the way of getting is fabric enabled
| @@ -1,4 +1,4 @@ | |||
| - label: ":android::react: RN .76 + Android: Demo app" | |||
| - label: ":android::react: (New Arch) - RN .76 + Android: Demo app" | |||
There was a problem hiding this comment.
Why not testing both new arch and old arch on .76?
Is that a breaking change?
There was a problem hiding this comment.
I think it's ok for the demo app but the question is valid for the main test app; By now we know the backwards compatibility is feasible with a reasonable effort so let's do it
Also, no need to put "New Arch" in this specific pipeline's name
|
@gosha212 I think the test app will crash on the Localization screen on Android, since it uses a legacy native module. |
|
we should check if our bridge native modules work with backward comp. or if there's something magically /hybrid that happens here |
Description
In this pull request, I have added support for the new arch in detox